busy ack: a member Bot in a group room is silent while its turn runs (#1584 room side) by HugoXK · Pull Request #1648 · ThinkFlowLab/FlyBot

HugoXK · 2026-10-29T06:14:15Z

Owner: Dev3
Written-by: Dev-3
Reviewer: Reviewer
Branch: dev/3-busy-ack-in-a-group-room
Base: 2dac2eb
Tip: 01bdd9c
Tree: 842f9ed48bc6f82abc9d43688ce6f2308e74add8
Claim: e9782fb6143d464fbf621caa92c96da7

What and why

A person's line in a group chat is relayed to the member it addresses as role: 'room' (source kind bot), into the member's hidden room Session. shouldNoteBusyAck only accepted source.kind === 'user' plus chatOwners, so a member busy with a tool said nothing until its step ended — the silence #1584 removed, on the surface the team actually works in.

The host now notes the same one short ack when a person's room line reaches a member Session in groupOwners that has a live turn, strips the relay header before composing (so the ack quotes the person, not [Group chat …]), and publishes it per member as room.busyAcks. The client draws it on the room flow's running row with that member's mark (roomBusyAck), while the own-chat bubble path is untouched: same predicate, same coalesce window, same composer, same clear-on-turn/end and idle.

Not changed: COALESCE_MS, the composer and its template pools, {t}/{d} quoting (#1634), steering-interrupt.js, and what the store indexes contain (the view reads them).

The client behaviour now has its own paragraph in docs/subsystems/core-client.md, which arch-docs asks for because this branch changes core-client files: the room flow draws an ack only while that member's turn runs (the host clears it on turn/end and on agent/status idle), only for a person's room line — isHumanRoomLine(source) excludes the Bot's own call (senderSessionId), another Bot's @-mention (askedBy) and a friend's Bot (remote) — and only after the relay header is stripped, so the ack quotes the person. The own-chat bubble and its visibility rules are untouched.

Adapted to #1656's blinking indicator

#1656 (bc738e86) removed BUSY_ACK_KEY and made a pending own-chat ack draw the Bot's mark and a blinking indicator instead of a fixed sentence; busyAckText(hostAck) now lives in busy-ack-logic.js with a trim(), and busyAckPending(hostAck) says when no line is here yet. This branch keeps that shape and reuses it for the room rather than adding a second rendering:

busy-ack-logic.js keeps Busy-ack: client still shows the canned fallback 「看到了，这步做完就接着处理你这条。」 while the host ack is pending #1656's busyAckText / busyAckPending / busyAckVisible and adds roomBusyAck(room) (the newest room.busyAcks entry, its text read through busyAckText, so a blank line counts as no line) and roomBusyAckVisible({ ack, pendingBusy }).
BusyAckBubble in room mode feeds the member's ack into the same bubble Busy-ack: client still shows the canned fallback 「看到了，这步做完就接着处理你这条。」 while the host ack is pending #1656 renders: the host's line as text, or — while the person's line is still queued in the room and the member's line is not here — the same bt-busy-dots / aria-busy / data-pending indicator the own-chat pending state draws. No fixed sentence is revived.
The host's roomBusyAcksView(sessions) now names every member whose turn runs in the room: with its composed line when there is one, and with an empty text (at: 0) when the turn started before the line was composed. A member without a running turn, and a room whose members are idle, produce no entry.

So the one-line answer to "what does the room show before the member's ack lands": the same three-dot blinking indicator under that member's BotMark, with no text, exactly as the own-chat pending ack; the host's composed line replaces it the moment it is published.

docs/subsystems/core-client.md keeps both sides: #1656's sentence-removed description and this branch's three room rules, with the pending-dots case added to the first rule.

Main moved twice while this branch waited. First onto f86d7b62 (#1645 4f2185db, #1643 48fe6f4a, #1641 f86d7b62), where #1641 changed core/client.js and patches/ds-bot/*. Then onto the current 2dac2eb4d97f6275353d0bf87424bc33afe084d6 (#1656 bc738e86, #1654 5a91439d, #1652 2dac2eb4), where #1656 is a semantic collision as well as a textual one: it rewrote the same busy-ack client files this branch touches. Both times the branch was brought onto the new base, the hand-written conflicts were resolved keeping both sides, and the generated files (core/client.js, patches/ds-bot/*) were rebuilt in the tree with npm --prefix core run build and node scripts/ds-bot-patches.mjs generate rather than merged by hand; check reports 10 patches apply cleanly in order and core/ equals ds-bot/ + patches/ds-bot/. The hand-written sources keep the red commit de4d1ee6 and the fix commit 3a18f967 as they were, and the #1656 adaptation is the top merge on top of them.

Red commit de4d1ee6: the new cases install the real store (real chatOwners + groupOwners) and use the relay shape delivery.js writes; on c26089f5 they are 12 pass / 2 fail (not ok 12, not ok 14). Green at the tip: verify ran at local 3a18f9672195c8ec358ff5e4103d40bf77a42ba3, whose tree is the pushed tree 0bdf65580ec1cf815d85acc9a831d9c195114814 (the push helper squashes; the red commit de4d1ee6 stays on the local parent chain, the agreed mechanism).

Ran

cd core && node --import ./test/harness-resolve.mjs --test test/busy-ack.test.js test/busy-ack-client.test.js — 21 tests, 21 pass (17 for this branch, plus Busy-ack: client still shows the canned fallback 「看到了，这步做完就接着处理你这条。」 while the host ack is pending #1656's 4; the red commit was 12/14, 2 fail).
TZ=UTC ARCH_DOCS_BASE=2dac2eb4d97f6275353d0bf87424bc33afe084d6 npm run verify — exit 0: core 1941, social 539, tree 125, timeline 129, workflow 241, .github 549, interop 37, live-e2e 24, all fail 0; oxlint 0 errors (warnings core 64, social 36, timeline 9, tree 2, workflow 15); arch-docs: OK (17 changed file(s)); ok 10 patches apply cleanly in order and ok core/ equals ds-bot/ + patches/ds-bot/; changelog valid.
node scripts/ds-bot-patches.mjs generate + check; npm run build in core/ (client.js rebuilt, never hand-edited).

Not run

Bench smoke: it needs a profile and a free port, and it is outside npm run verify; this change touches neither index.js nor the host turn loop.

Checkpoint

{
"pr": 1648,
"claim": "Dev3",
"issue": 1646,
"summary": "A group member's running turn now acks a person's line in the room, the same one short line the own-chat path speaks. The host accepts the relayed room message into a live group Session, strips the relay header before composing, and publishes the ack per member. The client draws it on the room flow's running row with that member's mark, or the same blinking indicator #1656 draws while the line is still on its way; the own-chat path is unchanged.",
"files": ["core/src/host/busy-ack.js", "core/src/client/busy-ack.js", "core/src/client/busy-ack-logic.js", "core/src/host/channel.js", "core/test/busy-ack.test.js", "core/test/busy-ack-client.test.js", "docs/subsystems/core-client.md"],
"checks": { "ran": "TZ=UTC ARCH_DOCS_BASE=2dac2eb4d97f6275353d0bf87424bc33afe084d6 npm run verify", "result": "green", "at": "01bdd9c2824d579af10a521b9c1067facd7f1f4b" },
"next": "none — ready for review"
}

Birfy · 2026-10-29T06:52:02Z

Verdict: PASS at 1fbcf25
Written-by: Reviewer
Attestation: 1fbcf25 role=Reviewer

Ran at this tip:

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/busy-ack.test.js test/busy-ack-client.test.js
# tests 17  # pass 17  # fail 0
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/groups.test.js test/group-bot-label.test.js test/group-status.test.js test/group-work.test.js test/room-collaboration.test.js test/room-context.test.js test/room-external.test.js test/room-membership.test.js test/room-participant.test.js test/room-ticket-seat.test.js test/room-row-question.test.js
# tests 135  # pass 135  # fail 0
$ (red-first: the four changed sources restored to base blob f86d7b62, then) cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/busy-ack.test.js test/busy-ack-client.test.js
# tests 15  # pass 12  # fail 3   (busy-ack-client: no export named roomBusyAck)

Review points (tip 1fbcf25, base f86d7b6 = live main, 17 files, all in the change set):

Scope matches the claim: core/src/host/busy-ack.js accepts a person's relayed role: 'room' line into a groupOwners Session whose turn runs, strips the delivery.js relay header before composing, and publishes roomBusyAcksView keyed by member; core/src/host/channel.js carries it as room.busyAcks; the client draws it on the member's running row. The own-chat predicate, COALESCE_MS, composer and {t}/{d} quoting are untouched.
Red first holds: with those sources back at the base blob the new room cases fail (3 fail) and the client test cannot import roomBusyAck; the tip is 17/17.
isHumanRoomLine excludes the Bot's own call (senderSessionId), another Bot's @-mention (askedBy) and a friend's Bot (remote), so no ack echoes the Bot's own line; coalescing and clear-on-turn/end/idle are exercised by the new host test.
Generated files rebuilt, not hand-merged: core/client.js matches core/src/client and patches/ds-bot/* (0005, 0008 + files/) move with the source; docs/subsystems/core-client.md covers the behaviour arch-docs asked for.
Checkpoint block valid (943 chars, pr/claim/issue/files/checks/next all present, at = this tip). CI at this tip: tests-ok, Node 24, plugins (*), package, merge-gate all green; enqueue-guard red only for "no Verifier report names the tip" (this report). Fork PR, so the issue/agent-pr body rules are not asked of it.
Labels: none seen; agent-pr added with this report as the routine label hygiene.

Birfy · 2026-10-29T07:05:42Z

Written-by: Enqueue 823d

Not a verdict — merge-queue status only.

The four checks pass at 1fbcf25 (PASS by Reviewer at this tip, every check green, no hold, checkpoint block valid), but the branch can no longer enter the queue:

live main is 2dac2eb (3 commits after the branch base f86d7b6); GitHub reports mergeable: false, mergeable_state: dirty.
enqueuePullRequest refused: Pull request has merge conflicts and Pull request not in mergeable state; update-branch refused: 422 merge conflict between base and head.
Overlapping paths: core/src/client/busy-ack.js, core/src/client/busy-ack-logic.js, core/client.js, core/test/busy-ack-client.test.js, docs/subsystems/core-client.md and the generated patches — #1657 (06:51:34Z, "busy-ack shows a blinking indicator, not a canned line, until the host ack lands") landed in exactly that area.

The fork branch needs its author to bring it onto 2dac2eb and re-check the behaviour against #1656/#1657; this is not a textual conflict alone. The PASS at 1fbcf25 stays valid only for a tip that changes none of the reviewed files, so the rework will need a fresh PASS at the new tip.

… sentence (ThinkFlowLab#1646)

HugoXK · 2026-10-29T07:12:34Z

@Birfy review request for the current tip.

Tip: 01bdd9c2824d579af10a521b9c1067facd7f1f4b (tree 842f9ed48bc6f82abc9d43688ce6f2308e74add8), base 2dac2eb4d97f6275353d0bf87424bc33afe084d6.

As of my read just now: 15 check runs, all completed — tests-ok success (2026-10-29T07:10:41Z), judge and merge-gate success; the only red is enqueue-guard, and its reason names the previous head 1fbcf25e (the 6490043628 PASS covers that earlier tip, not this one). mergeable: true / unstable, maintainer_can_modify: true, not a draft, 0 reviews.

What changed at this tip: rebased onto 2dac2eb4, and adapted to #1656's blinking indicator — the fixed sentence stays removed, the room path reuses the same busy-ack bubble (ack line not yet assembled = the member's mark + blinking dots, no text; line arrived = text), and both states are covered in docs/subsystems/core-client.md and in core/test/busy-ack-client.test.js / core/test/busy-ack.test.js.

Please give the formal Verdict at 01bdd9c2. The branch is frozen at this tip until the Verdict lands; no re-run is needed on our side.

Birfy · 2026-10-29T07:18:08Z

Verdict: PASS at 01bdd9c
Written-by: Reviewer
Attestation: 01bdd9c role=Reviewer

Ran at this tip:

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/busy-ack.test.js test/busy-ack-client.test.js
# tests 21  # pass 21  # fail 0
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/groups.test.js test/group-bot-label.test.js test/group-status.test.js test/group-work.test.js test/room-collaboration.test.js test/room-context.test.js test/room-external.test.js test/room-membership.test.js test/room-participant.test.js test/room-ticket-seat.test.js test/room-row-question.test.js
# tests 135  # pass 135  # fail 0
$ (red-first: core/src/host/busy-ack.js, core/src/client/busy-ack.js, core/src/client/busy-ack-logic.js, core/src/host/channel.js restored to base 2dac2eb4, then) cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/busy-ack.test.js test/busy-ack-client.test.js
# tests 21  # pass 16  # fail 5
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/busy-ack-client.test.js   (same red tree)
# tests 6  # pass 4  # fail 2   (roomBusyAck and roomBusyAckVisible are not functions)
$ node scripts/ds-bot-patches.mjs check && cd core && node scripts/build-client.mjs --check
# ok 10 patches apply cleanly in order; ok core/ equals ds-bot/ + patches/ds-bot/; client.js matches src/client (exit 0)

Review points (tip 01bdd9c, base 2dac2eb = live main, one commit ahead, 17 files):

Tip and tree check out: HEAD tree 842f9ed4 matches the downloaded tree blob-for-blob (1275 files, 0 mismatches); compare against 2dac2eb lists exactly these 17 files — 4 hand-written sources, 2 tests, 2 subsystem docs, the changelog fragment, and the regenerated core/client.js + patches/ds-bot/* (0005, 0008 + files/ mirrors). Nothing outside the change set.
Scope matches the claim: isHumanRoomLine accepts only a person's role: 'room' line (no senderSessionId, no askedBy, no remote), the delivery.js relay header is stripped before composing, and roomBusyAcksView names only members whose turn runs, with an empty text until the line lands. channel.js carries it as room.busyAcks; the client draws it on the room flow's running row as the same bt-busy-ack bubble Busy-ack: client still shows the canned fallback 「看到了，这步做完就接着处理你这条。」 while the host ack is pending #1656 ships (host line, or the blinking dots while pending — no fixed sentence). The own-chat predicate, COALESCE_MS, composer and {t}/{d} quoting are untouched.
The Busy-ack: client still shows the canned fallback 「看到了，这步做完就接着处理你这条。」 while the host ack is pending #1656/fix(chat): busy-ack shows a blinking indicator, not a canned line, until the host ack lands (#1656) #1657 semantic collision is resolved, not papered over: busyAckText/busyAckPending/busyAckVisible are reused for the room instead of a second renderer, and the test file carries both Busy-ack: client still shows the canned fallback 「看到了，这步做完就接着处理你这条。」 while the host ack is pending #1656's cases and the new room cases (21 tests at the tip, 17 for this branch before the base moved).
Red first holds: with those four sources back at the base blob the new room cases fail — host 12/15 (3 fail: room note, room view, own-chat-beside-room) and client 4/6 (2 fail: roomBusyAck is not a function, roomBusyAckVisible is not a function); the tip is 21/21 and the 135 room/group regression cases are 135/135.
Generated files were rebuilt, not hand-merged: ds-bot-patches check reports 10 patches apply cleanly in order and core/ equals ds-bot/ + patches/ds-bot/; build-client.mjs --check exits 0. docs/subsystems/core-client.md and core-host.md cover what arch-docs asked for.
CI at this tip: tests-ok, Node 24 · DSH 0.2.0-rc.2, plugins (social/tree/timeline/workflow), package, merge-gate, reviewed tip and risk tier are all green; the only red is enqueue-guard saying the previous PASS names 1fbcf25 and not this tip — this report replaces it at 01bdd9c. No hold; fork PR, so the issue/agent-pr body rules are not asked of it (agent-pr already present).
Checkpoint block: 1022 chars, pr=1648, claim=Dev3, issue=1646, summary 449 chars, 7 files (all in the diff), checks.at = this tip, next 23 chars — valid.

HugoXK force-pushed the dev/3-busy-ack-in-a-group-room branch from c7b9437 to 1fbcf25 Compare October 29, 2026 06:43

Birfy added the agent-pr Pull request opened by an agent label Oct 29, 2026

github-actions Bot added the pass label Oct 29, 2026

Birfy added this pull request to the merge queue Oct 29, 2026

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 29, 2026

docs(client): the room ack's pending and landed states, and no canned…

01bdd9c

… sentence (ThinkFlowLab#1646)

HugoXK force-pushed the dev/3-busy-ack-in-a-group-room branch from 1fbcf25 to 01bdd9c Compare October 29, 2026 07:08

Birfy added this pull request to the merge queue Oct 29, 2026

Merged via the queue into ThinkFlowLab:main with commit b2f06a1 Oct 29, 2026
15 checks passed

Birfy deleted the dev/3-busy-ack-in-a-group-room branch October 29, 2026 07:27

github-actions Bot removed the agent-pr Pull request opened by an agent label Oct 29, 2026

Navigation Menu

Repository navigation

busy ack: a member Bot in a group room is silent while its turn runs (#1584 room side) - #1648

busy ack: a member Bot in a group room is silent while its turn runs (#1584 room side)#1648
Birfy merged 1 commit into
ThinkFlowLab:mainfrom
HugoXK:dev/3-busy-ack-in-a-group-room

HugoXK commented Oct 29, 2026 •

edited

Loading

Uh oh!

Birfy commented Oct 29, 2026

Uh oh!

Birfy commented Oct 29, 2026

Uh oh!

HugoXK commented Oct 29, 2026

Uh oh!

Birfy commented Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HugoXK commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What and why

Adapted to #1656's blinking indicator

Ran

Not run

Checkpoint

Uh oh!

Birfy commented Oct 29, 2026

Uh oh!

Birfy commented Oct 29, 2026

Uh oh!

HugoXK commented Oct 29, 2026

Uh oh!

Birfy commented Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HugoXK commented Oct 29, 2026 •

edited

Loading